Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[new release] lwt_ssl (1.2.0) #23214

Merged
merged 1 commit into from
Feb 7, 2023
Merged

[new release] lwt_ssl (1.2.0) #23214

merged 1 commit into from
Feb 7, 2023

Conversation

anmonteiro
Copy link
Contributor

OpenSSL binding with concurrent I/O

CHANGES:

@anmonteiro
[new release] lwt_ssl (1.2.0)
61a6d4a 
CHANGES:

  * add Lwt_ssl.close_notify to issue one-way SSL shutdown (ocsigen/lwt_ssl#2, @madroach).
  * use Lwt.pause instead of the deprecated Lwt_unix.yield (ocsigen/lwt_ssl#3, @anmonteiro).
@anmonteiro
Copy link
Contributor Author

revdeps look good, only failure seems to be unrelated (building an example in kinetic-client.0.0.9)

@raphael-proust
Copy link
Collaborator

Maybe we can also add this diff at the same time to avoid breaking kinetic-client (even though it's "just an old version")

diff --git a/packages/kinetic-client/kinetic-client.0.0.9/opam b/packages/kinetic-client/kinetic-client.0.0.9/opam
index beac9a7902..ae6ee09fe7 100644
--- a/packages/kinetic-client/kinetic-client.0.0.9/opam
+++ b/packages/kinetic-client/kinetic-client.0.0.9/opam
@@ -17,7 +17,7 @@ depends: [
   "ocamlbuild" {build}
   "lwt" {> "3.2.0"}
   "lwt_log"
-  "lwt_ssl"
+  "lwt_ssl" {< "1.2.0"}
   "cryptokit"
   "ppx_deriving"
   "cmdliner"

@anmonteiro
Copy link
Contributor Author

Done.

@kit-ty-kate
Copy link
Member

kinetic-client.0.0.9 fails for another unrelated reason. I’ve reverted to the original commit which was fine.

Thanks

@kit-ty-kate kit-ty-kate merged commit 0e05fbf into ocaml:master Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anmonteiro @raphael-proust @kit-ty-kate